Conversation
✅ Sentry found no issues in your recent changes ✅ |
| rollups_to_update: list[DailyTestRollup] = [] | ||
|
|
||
| flaky_tests = list(curr_flakes.keys()) | ||
| with django_transaction.atomic(): |
There was a problem hiding this comment.
instead of indenting all of this code, how about moving the transaction to the caller (along with the trailing log and return statement)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 449 449
Lines 36864 36866 +2
=======================================
+ Hits 36026 36028 +2
Misses 838 838
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
we recently turned autocommit back on by default, but in the case of the process flakes task we explicitly want it on.
joseph-sentry
force-pushed
the
joseph/fix-proc-flake
branch
from
d3a2181 to
7c1e4c1
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
2 participants
we recently turned autocommit back on by default, but in the case of the process flakes task we explicitly want it on.